Add null checks to ColladaMeshShape.java #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Pull-request from @christianliebl containing additional null-checks to ColladaMeshShape to allow for Collada models without textures to be loaded.
Why Should This Be In Core?
This is a simple oversight that should have been included in the initial class. The null-check is already present in the getInstanceMaterial() method. Adding it to getTextureSource() and getEffect() allows for Collada models without textures to be loaded.
Benefits
Collada models without textures can now be loaded.
Potential Drawbacks
None
Applicable Issues
None